Skip to content

Conversation

@audunn
Copy link
Member

@audunn audunn commented Nov 14, 2025

Related command
az netappfiles

Description

Testing Guide

History Notes

[NetAppFiles] az netappfiles volume-group create: Add --network-features parameter for volume groups
[NetAppFiles] az netappfiles volume replication list : Add --exclude parameter to exclude deleted replications


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings November 14, 2025 15:29
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 14, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 14, 2025

⚠️AzureCLI-BreakingChangeTest
⚠️netappfiles
rule cmd_name rule_message suggest_message
⚠️ 1008 - ParaPropAdd netappfiles account ad add cmd netappfiles account ad add update parameter password: added property nargs=?
⚠️ 1010 - ParaPropUpdate netappfiles account ad add cmd netappfiles account ad add update parameter password: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate netappfiles account ad add cmd netappfiles account ad add update parameter password: updated property type from string to Password
⚠️ 1008 - ParaPropAdd netappfiles account ad add cmd netappfiles account ad add update parameter server_root_ca_certificate: added property nargs=?
⚠️ 1010 - ParaPropUpdate netappfiles account ad add cmd netappfiles account ad add update parameter server_root_ca_certificate: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate netappfiles account ad add cmd netappfiles account ad add update parameter server_root_ca_certificate: updated property type from string to Password
⚠️ 1008 - ParaPropAdd netappfiles account ad update cmd netappfiles account ad update update parameter password: added property nargs=?
⚠️ 1010 - ParaPropUpdate netappfiles account ad update cmd netappfiles account ad update update parameter password: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate netappfiles account ad update cmd netappfiles account ad update update parameter password: updated property type from string to Password
⚠️ 1008 - ParaPropAdd netappfiles account ad update cmd netappfiles account ad update update parameter server_root_ca_certificate: added property nargs=?
⚠️ 1010 - ParaPropUpdate netappfiles account ad update cmd netappfiles account ad update update parameter server_root_ca_certificate: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate netappfiles account ad update cmd netappfiles account ad update update parameter server_root_ca_certificate: updated property type from string to Password
⚠️ 1010 - ParaPropUpdate netappfiles check-name-availability cmd netappfiles check-name-availability update parameter type: updated property choices from ['Microsoft.NetApp/netAppAccounts', 'Microsoft.NetApp/netAppAccounts/capacityPools', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/snapshots'] to ['Microsoft.NetApp/netAppAccounts', 'Microsoft.NetApp/netAppAccounts/backupVaults/backups', 'Microsoft.NetApp/netAppAccounts/capacityPools', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/backups', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/snapshots']
⚠️ 1010 - ParaPropUpdate netappfiles check-quota-availability cmd netappfiles check-quota-availability update parameter type: updated property choices from ['Microsoft.NetApp/netAppAccounts', 'Microsoft.NetApp/netAppAccounts/capacityPools', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/snapshots'] to ['Microsoft.NetApp/netAppAccounts', 'Microsoft.NetApp/netAppAccounts/backupVaults/backups', 'Microsoft.NetApp/netAppAccounts/capacityPools', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/backups', 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/snapshots']
⚠️ 1010 - ParaPropUpdate netappfiles pool create cmd netappfiles pool create update parameter custom_throughput_mibps: updated property aaz_type from float to int
⚠️ 1010 - ParaPropUpdate netappfiles pool create cmd netappfiles pool create update parameter custom_throughput_mibps: updated property type from float to int
⚠️ 1010 - ParaPropUpdate netappfiles pool update cmd netappfiles pool update update parameter custom_throughput_mibps: updated property aaz_type from float to int
⚠️ 1010 - ParaPropUpdate netappfiles pool update cmd netappfiles pool update update parameter custom_throughput_mibps: updated property type from float to int
⚠️ 1006 - ParaAdd netappfiles volume replication list cmd netappfiles volume replication list added parameter exclude
⚠️ 1006 - ParaAdd netappfiles volume-group create cmd netappfiles volume-group create added parameter shared_network_features

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Azure NetApp Files API version from 2025-06-01 to 2025-09-01 and adds support for the --shared-network-features parameter in volume group operations. The changes include:

  • API version update across all service calls
  • New --shared-network-features parameter for volume groups with Basic/Standard enum values
  • Test location change from eastus2euap to eastus
  • Updated test recordings to reflect the new API version and timestamps

Reviewed Changes

Copilot reviewed 146 out of 204 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test_pool_commands.py Changed test location from eastus2euap to eastus
test_update_snapshot_policy.yaml Updated test recordings with new API version 2025-09-01
test_update_pool.yaml Updated test recordings with new API version and location change
test_update_account.yaml Updated test recordings with new API version
test_region_info_show.yaml Updated test recordings with new API version
test_region_info_list.yaml Updated test recordings with new API version
test_get_region_info.yaml Updated test recordings with new API version
test_check_quota_availability.yaml Updated test recordings with new API version
test_check_name_availability.yaml Updated test recordings with new API version
custom.py Fixed logging comment, added shared-network-features parameter support, and propagated it through all volume creation functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@audunn
Copy link
Member Author

audunn commented Nov 14, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32423 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 15, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 16, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32423 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 16, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 17, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32423 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32423 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 19, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32423 in repo Azure/azure-cli

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kairu-ms kairu-ms merged commit a3c0f4b into Azure:dev Nov 20, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot NetAppFiles az netappfiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants